Skip to content
This repository has been archived by the owner on May 7, 2019. It is now read-only.

Switches do not need text #225

Open
valadas opened this issue Feb 18, 2019 · 0 comments
Open

Switches do not need text #225

valadas opened this issue Feb 18, 2019 · 0 comments
Milestone

Comments

@valadas
Copy link
Contributor

valadas commented Feb 18, 2019

Describe the bug

The Dnn Switches in the common components are not localized in the provided french language pack.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any persona bar module that uses switches

Expected behavior

Text should not be required on the switches. They do not always represent On/Off, sometimes the meaning should be Enabled/Disabled or Yes/No.
image

Furthermore on many languages the words On/Off is much longer than 2 or 3 letters and the switches are usually placed in a very tight spot which may not have to room for words like (Allumé/Éteint or Activé/Désactivé) and so on. Also if the language pack does not have that value, they show SwitchOn or SwitchOff.
image

The switch position and color should be enough for people to understand when they are on or off. For accessibility reasons, we can leave it there but not visible, as aria tags or just with a css rule that hides them for screens/print but keeps them for screenreaders.

Screenshots

@valadas valadas changed the title are not localized in default french language pack Switches do not need text Feb 18, 2019
@valadas valadas added this to the 9.3.1 milestone Mar 2, 2019
@valadas valadas modified the milestones: 9.3.1, 9.4.0 Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant