Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doom-homage themes break consult-theme preview #839

Open
SlobDad opened this issue Sep 27, 2024 · 1 comment
Open

doom-homage themes break consult-theme preview #839

SlobDad opened this issue Sep 27, 2024 · 1 comment
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet

Comments

@SlobDad
Copy link

SlobDad commented Sep 27, 2024

Theme(s)

doom-homage-black, doom-homage-white

What were you expecting?

The Consult package has a command called consult-theme that allows you to scroll through themes, previewing them as you do so. Scrolling through doom-themes loads each theme in turn as you scroll through them. Hitting return exits the preview leaving the last theme loaded in effect.

What actually happened?

When scrolling through themes using consult-theme, the doom-homage-black-theme and doom-homage-white-theme break the preview, and it gets stuck on that theme. And at least occasionally seems to break the ability to switch themes altogether, even by using other commands to do so.
This happens at least when visiting an org-mode buffer during the preview, not sure about others.
No error messages, but some of this from Messages might be related:

QuitWarning: setting attribute ‘:background’ of face ‘outline-1’: nil value is invalid, use ‘unspecified’ instead.
Error in post-command-hook (consult--preview-post-command-hook): (error "Invalid face box" :line-width -1 :color "#5B6268" :style 'released-button)
face-spec-set-2: Invalid face box: :line-width, -1, :color, "#5B6268", :style, 'released-button

I do not know if this is a Consult bug or a doom-themes bug, also reporting to Consult

Steps to reproduce

  1. Open an org-mode buffer
  2. M-X consult-theme
  3. scroll down to doom-homage-white or doom-homage-black
  4. try to scroll to the next theme

Operating system

macOS

Emacs version

GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.0.0, NS appkit-2487.00 Version 14.0 (Build 23A344)) of 2024-02-17

Installed commit of doom-themes

version: 2.3.0 ff26f26

@SlobDad SlobDad added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Sep 27, 2024
@gagbo
Copy link
Member

gagbo commented Sep 27, 2024

Don’t mind me, I’m just putting the root cause asap for faster triage

1

https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html

The value of style specifies whether to draw a 3D box. If it is released-button, the box looks like a 3D button that is not being pressed. If it is pressed-button, the box looks like a 3D button that is being pressed. If it is nil, flat-button or omitted, a plain 2D box is used.

2

Emacs started errorring on invalid style values (in 30 preview I guess?? see agraul/doom-alabaster-theme#1)

3

Double quoting in org-thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet
Projects
None yet
Development

No branches or pull requests

2 participants