Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source index build step #25096

Closed
davidfowl opened this issue Jun 14, 2021 · 4 comments
Closed

Add source index build step #25096

davidfowl opened this issue Jun 14, 2021 · 4 comments
Labels
area-infrastructure closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone

Comments

@davidfowl
Copy link
Member

See dotnet/runtime#46823 for more details. This allows EF core to show up in https://source.dot.net/

cc @alexperovich
cc @bricelam

@dougbu
Copy link
Member

dougbu commented Jun 15, 2021

@bricelam this change looks straightforward and is something we should do together w/ dotnet/aspnetcore#33534. @dotnet/aspnet-build should make short work of it.

@AndriySvyryd AndriySvyryd added this to the MQ milestone Jun 15, 2021
@bricelam
Copy link
Contributor

enableRichCodeNavigation and source-index-stage1.yml?? Doesn't seem very DRY... :trollface:

@alexperovich
Copy link
Member

To simplify this change, if the repo uses eng/common/templates/jobs/jobs.yml, you can just set the "enableSourceIndex" parameter there. If the code to be indexed gets built by default with eng/common/build.ps1, then you can stop there. Otherwise the sourceIndexBuildCommand value in the sourceIndexParams parameter will need to be set to the command that will produce a binlog containing builds of all the projects to be indexed.

@bricelam bricelam removed their assignment Jul 8, 2023
@AndriySvyryd
Copy link
Member

This is done from the EF side. Opened dotnet/source-indexer#116 to track the remaining work.

@ajcvickers ajcvickers modified the milestones: MQ, 9.0.0 Nov 14, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 14, 2023
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
@roji roji modified the milestones: 9.0.0-preview1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Development

No branches or pull requests

7 participants