Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Compat] Adding an ObsoleteAttribute or ExperimentalAttribute is not detected as a breaking change #45524

Open
bitbonk opened this issue Dec 18, 2024 · 1 comment
Labels
Area-ApiCompat untriaged Request triage from a team member

Comments

@bitbonk
Copy link

bitbonk commented Dec 18, 2024

Is your feature request related to a problem? Please describe.

When adding the ObsoleteAttribute or ExperimentalAttribute to an existing public API, these changes are not detected as a source breaking changes by the baseline package validator. Such changes are not source compatible because the former would result in a new compiler warning in consuming code and the latter even a compiler error.

Describe the solution you'd like

Introduce two new validation checks. One for ObsoleteAttribute and one for ExperimentalAttribute that fails when the attribute is added to a public API that existed without that attribute in the basline version without the attribute.

Additional context

In .NET 9, obsoletions where also documented as source-incompatible breaking changes.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Dec 18, 2024
Copy link
Contributor

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant