-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ItemClick doesn't work with stateReducer inside an iframe #1237
Comments
Indeed it's broken. It triggers a blur instead of item click. It should be investigated. Maybe something in our logic that triggers input blur is broken. Maybe in |
@silviuaavram Line 127 passed in |
Well, it was not needed. The function was copy pasted from Downshift, added to a hook to be re-used, and it was not needing any items for its purpose. @jenn-jenn But if the fix requires the items to be passed I have no problem with that. |
@DeyLak @jenn-jenn Can you check if |
Any update on this. The issue is still reproduceable. But only when used iframe in iOS browsers. @DeyLak did you manage to get this fixed, facing the similar issue. @silviuaavram updated to 6.1.3 but still has the same issue. Any help will be appreciated. |
@rrabii can you go ahead and try to fix it? I am unable to work on this at the moment, but if you submit a PR and looks good I will merge it. Thanks! |
@silviuaavram alright, will take a look. |
Any progress with this issue? |
downshift
version: 6.1.0node
version: codesandboxnpm
(oryarn
) version: codesandboxWhat you did:
I tried to combine the default example of multiple select and that state reducer part to achieve my dropdown not being closed after item click. I also wrap it in an iframe(using
react-frame-component
), cause I have such setup for my components in the documentation environment.What happened:
ItemClick change type doesn't trigger stateReducer, which causes menu to close, although InputKeyDownEnter does.
Reproduction repository:
https://codesandbox.io/s/gallant-meadow-660h4?file=/src/index.js
Problem description:
stateReducer
doesn't fire withuseCombobox.stateChangeTypes.ItemClick
inside an iframeSuggested solution:
I could implement the fix with some advise help. Do you have any idea, what causes this?
The text was updated successfully, but these errors were encountered: