Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remember-ui import path improve #21

Open
qkraudghgh opened this issue Feb 10, 2021 · 0 comments
Open

remember-ui import path improve #21

qkraudghgh opened this issue Feb 10, 2021 · 0 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@qkraudghgh
Copy link
Contributor

qkraudghgh commented Feb 10, 2021

현재 color, mixin, component, typo 이렇게 총 4가지의 경우가 있는데 이를 나누지않고 import 해서 사용하고 있다
아래와 같이 개선하는것은 어떨지?

// As-is
import { yellow100, webOnly, NewBaseButton } from "remember-ui";

// To-be
import { yellow100 } from "remember-ui/color";
import { webOnly } from "remember-ui/mixin";
import { NewBaseButton } from "remember-ui/component";
@qkraudghgh qkraudghgh added the help wanted Extra attention is needed label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants