-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added models for token transfers and balance for Gnosis #5926
Conversation
Workflow run id 9101414919 approved. |
Workflow run id 9101415158 approved. |
Workflow run id 9101878016 approved. |
Workflow run id 9101878188 approved. |
Workflow run id 9109524394 approved. |
Workflow run id 9109524722 approved. |
Workflow run id 9123867224 approved. |
Workflow run id 9123867410 approved. |
Workflow run id 9126472351 approved. |
Workflow run id 9126472167 approved. |
Workflow run id 9149918728 approved. |
Workflow run id 9149918772 approved. |
Workflow run id 9150050147 approved. |
Workflow run id 9150050172 approved. |
Workflow run id 9159528070 approved. |
Workflow run id 9159528314 approved. |
Workflow run id 9187155608 approved. |
Workflow run id 9187155834 approved. |
Workflow run id 9210136693 approved. |
@jeff-dude PR is ready. Suicide model is not incremental, it computes the contract balance up to the suicide call. |
Workflow run id 9992794134 approved. |
Workflow run id 9992794491 approved. |
Workflow run id 9994154974 approved. |
Workflow run id 9994155227 approved. |
Workflow run id 9994600163 approved. |
Workflow run id 9994600502 approved. |
Workflow run id 9996472516 approved. |
Workflow run id 9996472929 approved. |
Workflow run id 10091128758 approved. |
Workflow run id 10091129020 approved. |
Workflow run id 10102258166 approved. |
Workflow run id 10102258413 approved. |
thank you for continued patience on this PR. i will try to revisit asap to see how we can consolidate transfers as efficiently as possible across spellbook. |
Workflow run id 10160343019 approved. |
sorry for the inconvenience, but we completed multi-project setup in spellbook while this PR was open. to fix merge conflicts, your code should now live in |
@jeff-dude created a new PR #6480 to accommodate the new structure. |
I am closing this PR and moving to the new one |
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Best practices
To speed up your development process in PRs, keep these tips in mind:
readme
) and rundbt compile
target/
directory to copy/paste and run on Dune directly for initial query testingWHERE
filter for only ~7 days of history on large source tables, i.e.ethereum.transactions
Incremental model setup
COALESCE()
as needed on key column(s), otherwise the tests may fail on duplicates🪄 Use the built CI tables for testing 🪄
Once CI completes, you can query the CI tables and errors in dune when it finishes running.
run initial models
andtest initial models
, there will be a schema that looks like this:test_schema.git_dunesql_4da8bae_sudoswap_v2_base_pool_creations
Leverage these tables to perform QA testing on Dune query editor -- or even full test dashboards!
Spellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.md
file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝