-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hivemapper model created #5997
hivemapper model created #5997
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Workflow run id 9243750576 approved. |
I have read the CLA Document and I hereby sign the CLA |
Workflow run id 9244271872 approved. |
Workflow run id 9245736027 approved. |
Workflow run id 9245736040 approved. |
Workflow run id 9251998966 approved. |
Workflow run id 9251999188 approved. |
Workflow run id 9252141107 approved. |
Workflow run id 9252141564 approved. |
Workflow run id 9252301861 approved. |
Workflow run id 9252301957 approved. |
Workflow run id 9252448910 approved. |
Workflow run id 9252449101 approved. |
Workflow run id 9252665254 approved. |
Workflow run id 9252665515 approved. |
Workflow run id 9252986128 approved. |
Workflow run id 9289083611 approved. |
Workflow run id 9291287167 approved. |
Workflow run id 9291287387 approved. |
Workflow run id 9301660494 approved. |
Workflow run id 9301660792 approved. |
Workflow run id 9304240655 approved. |
Workflow run id 9304240918 approved. |
Workflow run id 9305366837 approved. |
Workflow run id 9305366937 approved. |
Workflow run id 9306913971 approved. |
Workflow run id 9306914108 approved. |
Workflow run id 9308932457 approved. |
Workflow run id 9308932708 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed a final commit myself, since i forgot to ask in review :) essentially filters the target data to the same timeframe as source data, to make merge faster on incremental runs.
thanks for implementing the feedback!
thanks for the commit! How long does it usually take to merge the new model into the repo? |
typically same day or next day, but we had some changes in prod end of last week to block us from merging. that isn't typical. i am working through the list of merges today. |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Best practices
To speed up your development process in PRs, keep these tips in mind:
readme
) and rundbt compile
target/
directory to copy/paste and run on Dune directly for initial query testingWHERE
filter for only ~7 days of history on large source tables, i.e.ethereum.transactions
Incremental model setup
COALESCE()
as needed on key column(s), otherwise the tests may fail on duplicates🪄 Use the built CI tables for testing 🪄
Once CI completes, you can query the CI tables and errors in dune when it finishes running.
run initial models
andtest initial models
, there will be a schema that looks like this:test_schema.git_dunesql_4da8bae_sudoswap_v2_base_pool_creations
Leverage these tables to perform QA testing on Dune query editor -- or even full test dashboards!
Spellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.md
file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝