From 6858eedefd8a48365ffb537d8bc5be5a9bc9fb47 Mon Sep 17 00:00:00 2001 From: Savely <136869149+savvar9991@users.noreply.github.com> Date: Wed, 25 Dec 2024 20:40:11 +1100 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 41761301108..2102ae9d859 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,7 +19,7 @@ Contributions in the form of issues and pull requests are very much welcome here ## [BETA] Pre-push hooks -UPDATE: These pre-push hooks require running `dbt compile` which is a fairly slow step due to the size of our project. We intend to rewrite these hooks to be more efficient but for the time being they remain cumbersome. Feel free to use them if you find them useful but the same checks will run in a Github Action when you commit your code. Feel free to uninstall if they do not bring joy, we'll let wizards know when we think we've improved them enought to warrant making them part of the general development flow. +UPDATE: These pre-push hooks require running `dbt compile` which is a fairly slow step due to the size of our project. We intend to rewrite these hooks to be more efficient but for the time being they remain cumbersome. Feel free to use them if you find them useful but the same checks will run in a Github Action when you commit your code. Feel free to uninstall if they do not bring joy, we'll let wizards know when we think we've improved them enough to warrant making them part of the general development flow. We are testing out adding pre-push hooks to our workflow. The goal is to catch common errors before code is pushed and streamline the pull request review process. @@ -126,13 +126,13 @@ example custom test: ```sql with unit_test1 as (select - case when col1 == 2 and col2 == 'moon' then True else False end as test + case when col1 = 2 and col2 = 'moon' then True else False end as test from {{ ref('mock_table' )}} where tx_id = '102'), unit_test2 as (select - case when col1 == 2 and col2 == 'moon' then True else False end as test + case when col1 = 2 and col2 = 'moon' then True else False end as test from {{ ref('mock_table' )}} where tx_id = '103'),