Info extractor rework #890
Labels
help wanted
Extra attention is needed
refactor
Something needs to be reworked to improve code quality
server
Improvements or additions to the server
The info extractor has some problems that make implementing new features hard.
Video
or array ofVideo
Video
is, resulting in lots of duplicate code.Video
s whereservice != adapter.serviceId
startAt
andendAt
metadata that is embedded into the url (eg. youtube'st=5s
query parameter for starting the video at 5 seconds)https://www.youtube.com/watch?v=OtqD0ddbLic&list=PLqKpXXbHNvC83j0C8UsR817qcrXupLGZ5
)I want the new info extractor to be able to:
startAt
andendAt
)So far, what I'm thinking, when diagrammed out, is this:
This isn't perfect or complete, and I'll be refining it and updating this issue.
Some notes:
CollectionId
,page
is a string so that it can either be a number or a page token (youtube api uses those)ServiceAdapter
should provide a default, overrideable impl forfetchMulti()
, allowing derived adapters to override it with something more optimized if applicable.The text was updated successfully, but these errors were encountered: