From 242cf3bb46716b18c7bddef023bcd2b1ba60871b Mon Sep 17 00:00:00 2001 From: "K. Shankari" Date: Sat, 21 Dec 2024 12:09:02 -0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5=20Stop=20failing=20the=20test=20if?= =?UTF-8?q?=20code=20coverage=20goes=20down?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We currently run tests and check code coverage in the same workflow, and fail if the code coverage goes down. But our current coverage is fairly limited (< 20%) so we have a lot of failures from changes to code that currently does not have any tests. Let's still check the code coverage, but disable the `fail_on_error` so it doesn't mask errors in the tests. Once we improve coverage to cover more areas, we can re-enable this. --- .github/workflows/code-coverage.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml index a97fb3925..76f6e4771 100644 --- a/.github/workflows/code-coverage.yml +++ b/.github/workflows/code-coverage.yml @@ -32,5 +32,4 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} files: ./coverage/coverage-final.json flags: unit - fail_ci_if_error: ${{ github.repository == 'e-mission/e-mission-phone' }}