Codecov Report

Merging #234 (97b8f1a) into main (554efe7) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   80.43%   80.57%   +0.13%     
==========================================
  Files          70       70              
  Lines        8093     8171      +78     
==========================================
+ Hits         6510     6584      +74     
- Misses       1223     1230       +7     
+ Partials      360      357       -3     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758c860...97b8f1a. Read the comment docs.

@jxd134 There are some warnings in your code which reported by glint, could you please help to fix them?

@haoel I will fix it in future commit.

I am now confused.
The pr put the socket read/write operations in two goroutines. When I actively close the socket, the read/write operation will report an exception. The key is that the thrown exception is difficult to distinguish whether it is caused by closing the socket or caused by a network exception.
The general practice is to set a timeout for socket read/write, and when a timeout exception is thrown, determine whether the connection is closed at this time. But which goroutine will close the socket after that, I don’t have a good idea now.

I am now confused. The pr put the socket read/write operations in two goroutines. When I actively close the socket, the read/write operation will report an exception. The key is that the thrown exception is difficult to distinguish whether it is caused by closing the socket or caused by a network exception. The general practice is to set a timeout for socket read/write, and when a timeout exception is thrown, determine whether the connection is closed at this time. But which goroutine will close the socket after that, I don’t have a good idea now.

Are you experiencing some specific reproducible error or is this more like a general question about the design? For directional channels the sender should close the channel but here the connections are bidirectional, right?

I am now confused. The pr put the socket read/write operations in two goroutines. When I actively close the socket, the read/write operation will report an exception. The key is that the thrown exception is difficult to distinguish whether it is caused by closing the socket or caused by a network exception. The general practice is to set a timeout for socket read/write, and when a timeout exception is thrown, determine whether the connection is closed at this time. But which goroutine will close the socket after that, I don’t have a good idea now.

Are you experiencing some specific reproducible error or is this more like a general question about the design? For directional channels the sender should close the channel but here the connections are bidirectional, right?

yes, that's it

There is no time to solve it in the short term, so I can only choose to give up.
sorry