Provide API to reference "org.eclipse.cdt.debug.gdbjtag.core.jtagDevice" launch attribute

[ruspl-afed]

Currently we have IGDBJtagConstants#ATTR_JTAG_DEVICE_ID for "org.eclipse.cdt.debug.gdbjtag.core.jtagDeviceId" but nothing similar for "org.eclipse.cdt.debug.gdbjtag.core.jtagDevice"

This leads to a duplicated declarations even for Eclipse CDT code base

1. cdt/jtag/org.eclipse.cdt.debug.gdbjtag.core/src/org/eclipse/cdt/debug/gdbjtag/core/GDBJtagDSFFinalLaunchSequence.java

   Line 111 in 9b6bb07

   private static final String ATTR_JTAG_DEVICE = Activator.PLUGIN_ID + ".jtagDevice"; //$NON-NLS-1$

2. cdt/jtag/org.eclipse.cdt.debug.gdbjtag.ui/src/org/eclipse/cdt/debug/gdbjtag/ui/GDBJtagDSFDebuggerTab.java

   Line 83 in 9b6bb07

   private static final String ATTR_JTAG_DEVICE = "org.eclipse.cdt.debug.gdbjtag.core.jtagDevice"; //$NON-NLS-1$

It would be great to add API for this launch attribute

[jonahgraham]

Sorry that I didn't notice this when you submitted this issue, but this would undo 5188547 - see API notes: https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CHANGELOG-API.md#:~:text=IGDBJtagConstants.ATTR_JTAG_DEVICE%20has%20been%20removed.%20Use%20IGDBJtagConstants.ATTR_JTAG_DEVICE_ID%20to%20persist%20device%20ID%20rather%20than%20device%20name.%20See%20Bug%20566462.

If you think this is needed going forward (i.e. you want to undo 5188547) please loop in @jld01 to review.

[ruspl-afed]

No problem @jonahgraham and thank you for the links. I asked @jld01 to comment at #943

[ruspl-afed]

This appeared to be an intentional code duplication