Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Thing with PATCH (merge patch) semantic will retain null values which is invalid #2074

Closed
thjaeckle opened this issue Dec 10, 2024 · 0 comments · Fixed by #2082
Closed
Assignees
Labels
Milestone

Comments

@thjaeckle
Copy link
Member

In Ditto it is possible to also create Things with Merge updates.
This either updates an existing thing or creates it when it does not yet exist.

The implemented Merge Patch RFC 7396 defines that null values have a special meaning: they are used to delete fields from a JSON.

When Ditto however creates the Thing if it was not yet existing when doing a PATCH, this semantic is not applied which is not adhering to the RFC.
Ditto must therefore "delete" also JSON fields with null values when creating a not-yet existing Thing on a PATCH request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant