-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEPR-2U]: Remove md4 caching and related ENABLE_BLAKE2B_HASHING feature flag #872
Comments
First pass at instrumentation:
I can't remember if we'll actually be able to sum this information in DD? You might need to create an integer-based facet based on the span tag. Based on these findings, we may want logging with the actual keys, or we may feel it is safe enough if the with-hash percentage is low enough. |
FYI, the PR to remove the flag has been opened at openedx/edx-platform#36054 We won't merge it until y'all have resolved & closed this issue. |
Thanks! We're actually ready for this to proceed -- the remainder of this ticket is just communication and post-removal cleanup. |
Ok, the PR to remove the flag has been merged. Let me know if there's anything else we can do to help. |
We need to enable this feature flag in advance of its removal, detailed in the following DEPR:
Tim did mention possibly adding telemetry to better understand the impact before enabling in this comment on the PR where the toggle had been added:
Looking to complete this by April 2025.
Acceptance Criteria:
Implementation Tasks:
The text was updated successfully, but these errors were encountered: