Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: crash when macro lib files are gzipped #629

Merged
merged 2 commits into from
Jan 5, 2025
Merged

hotfix: crash when macro lib files are gzipped #629

merged 2 commits into from
Jan 5, 2025
+109 −16

Conversation

donn
Copy link
Member

@donn donn commented Jan 1, 2025 •
edited
Loading

  • Yosys.*
    • Fixed blackbox Verilog and lib models causing a crash if they are
      gzipped and/or have the extension .gz.

Tool Updates

  • Relaxed requirement on httpx to include 0.28.X, which has no removals
    compared to 0.27.0.

Resolves #622
Resolves #627

@donn
fix: crash when macro lib files are gzipped
ff5ae84 
* `Yosys.*`
  * Fixed blackbox Verilog and lib models causing a crash if they are
    gzipped and/or have the extension `.gz`.

## Tool Updates

* Relaxed requirement on `httpx` to include `0.28.X`, which has no removals
  compared to `0.27.0`.
@openlane-bot
Copy link
Collaborator

openlane-bot commented Jan 1, 2025 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch main --table-verbosity ALL --table-out ./tables_all.md.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/70a03c5e8303297944284cf73e270b56

@kareefardi
Copy link
Collaborator

Wouldn't this be considered a new feature? Support for gzipped verilog and lib files

@kareefardi
Copy link
Collaborator

Wouldn't this be considered a new feature? Support for gzipped verilog and lib files

Agreed to have it as a bugfix. Only item left is documentation.

@hpretl
Copy link
Collaborator

hpretl commented Jan 3, 2025

@donn @kareefardi Looking forward to this space-saving feature. When are you ready to release it?

@donn
Copy link
Member Author

donn commented Jan 5, 2025

Still need to document limitations-- for example, gzipped standard cell library lib files will still not work with this PR (pending upstream.) Should be out today.

@donn donn requested a review from kareefardi January 5, 2025 08:47
@kareefardi kareefardi enabled auto-merge (squash) January 5, 2025 09:50
@kareefardi kareefardi merged commit fbc2191 into main Jan 5, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kareefardi kareefardi kareefardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support gziped Liberty (.lib) files Support httpx for versions >= 0.28.x
4 participants
@donn @openlane-bot @kareefardi @hpretl