Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password prompt for password-protected videos is sometimes flashed for a short time #1290

Open
LukasKalbertodt opened this issue Dec 3, 2024 · 0 comments
Labels
area:frontend Everything frontend related kind:improvement priority:low Low priority

Comments

@LukasKalbertodt
Copy link
Member

This is caused by three distinct things:

  • (a) When a video page is visited and we have a password in local storage associated with its series, but not with the video id directly. Then the first request will not send a password, and only in a second request (once we have the series id to look up the password), the video is unlocked. In between, the password prompt is shown. This only happens once, as then the password is also associated with the event ID.

  • (b) A video block has the same problem but a bit worse: here, we can never send the password in the initial request, as we only know to show the blocks of a realm, so we cannot look up any passwords before receiving the information what blocks even exist.

  • (c) When navigating away from a realm page with a video block, while the new route loads, the old realm page component renders the password prompt for video blocks instead of the player. I don't know why this "reverts" to showing the password prompt while loading the new route.

For (a) and (b), we should somehow show in the password prompt, that a request is on its way. Otherwise, when the request takes a long time, the user might already input the password and then it suddenly unlocks on its own. One could also potentially use the local relay store to check if the series ID is already cached, at least for (a).

For (c), we need to investigate why this is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Everything frontend related kind:improvement priority:low Low priority
Projects
None yet
Development

No branches or pull requests

1 participant