You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When an API WG member has reviewed a PR and added feedback, I think we're supposed to add the api-review/reviewed label and remove the api-review/requested label. However, when we do that it looks like Cation automatically adds back the api-review/requested label (which triggers API WG notifications about a new PR).
If I'm understanding our API WG labeling system correctly, Cation should only be adding the api-review/requested label if no other api-review label (including api-review/reviewed) has been applied.
The text was updated successfully, but these errors were encountered:
cation doesn't let humans modify those labels on a PR, since that would sidestep things. If you want to add api-review/reviewed as an intermediate state between requested and approved/declined, the logic in this repo will need to be updated.
This PR illustrates the problem: electron/electron#40301
When an API WG member has reviewed a PR and added feedback, I think we're supposed to add the
api-review/reviewed
label and remove theapi-review/requested
label. However, when we do that it looks like Cation automatically adds back theapi-review/requested
label (which triggers API WG notifications about a new PR).If I'm understanding our API WG labeling system correctly, Cation should only be adding the
api-review/requested
label if no other api-review label (includingapi-review/reviewed
) has been applied.The text was updated successfully, but these errors were encountered: