Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object-centric grasp #3

Open
JudyYe opened this issue Feb 2, 2021 · 3 comments
Open

object-centric grasp #3

JudyYe opened this issue Feb 2, 2021 · 3 comments

Comments

@JudyYe
Copy link

JudyYe commented Feb 2, 2021

Hi,

Nice work! Thank you for releasing data and code!
As far as I understand, there are 3 sets of grasps. 1) 367 grasps from manual annotation. (sec3.1 para 1) 2) many more object-centric grasps generated by symmetry. (sec3.1 para 2) 3) transfer 2) to YCB-Video dataset after filtering collision (28M).

I notice that set 1 is in data/grasps, set 3 in YCB_Affordance_grasps. I wonder if set 2 is released. If not, could you please kindly provide the code of generation procedure from set1 to set2?

Thank you very much!

@enriccorona
Copy link
Owner

Hi,

Good point, this file contains the code to generate object-centric grasps after symmetry, and the generated grasps (set 2) of the final version of the dataset:
symmetry_code.zip

Set 2 contains a bit more than 800 grasps but you can create many more depending on a few hyperparameters. Actually, I thought we had more of them after this step. I haven't used the code for a while but I think it should work when setting correct paths.

Best,
Enric

@JudyYe
Copy link
Author

JudyYe commented Feb 3, 2021

Thank you for your quick reponse. I will run it today.

@JudyYe JudyYe closed this as completed Feb 3, 2021
@JudyYe
Copy link
Author

JudyYe commented Feb 13, 2021

Hi,

Thank you for providing symmetry code and data. However, could you please explain how to interpret / visualize the extended grasp?

I realize that you assign a new mano_trans and pca_manorot, which are used in visualize_grasps.py. However, when I visualize it in the same way as that for set1. I got the following figures:

image
(visualizing grasp_0_3.pkl)

I also notice that the core transformation is in Line 74-75.

    newpos = np.matmul(position, apply_rotmat)
    newrot = np.matmul(hand_rotmat, apply_rotmat)

But I don't quite understand it. Suppose positions are column vector (which seems true for MANO layer)

,where S is apply_rotmat.
I would assume the transformation just apply an additional rotation around object rotation axis (on the left). Mabye something like

, though it's not the exact form since rotational axis and MANO origin offset should also be considered.

I wonder if I misunderstood at some point and how to correctly visualize the generated grasps. Looking forward to your reply. Thank you!

@JudyYe JudyYe reopened this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants