Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on global state for HTTP transports #116

Open
zregvart opened this issue Sep 25, 2024 · 0 comments
Open

Don't rely on global state for HTTP transports #116

zregvart opened this issue Sep 25, 2024 · 0 comments

Comments

@zregvart
Copy link
Member

In #114 and #113 configurable http.RoundTripper was introduced to allow adding tracing & backoff/retry in EC CLI. The approach taken there relies on global state, we should try to not have the global state but a way to configure options, like http.RoundTripper, via per gather implementation instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zregvart