From 68e2738c68342532bc8005b863b2a4664bcaddb7 Mon Sep 17 00:00:00 2001
From: Tom L <98499638+expressvpn-tom-l@users.noreply.github.com>
Date: Wed, 18 Oct 2023 14:18:40 +0800
Subject: [PATCH] fixup: check return code of
 he_internal_pmtud_start_base_probing

---
 src/he/conn.c  | 4 +---
 src/he/pmtud.c | 3 +++
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/he/conn.c b/src/he/conn.c
index 92752b41..d7bbd1c4 100644
--- a/src/he/conn.c
+++ b/src/he/conn.c
@@ -1196,9 +1196,7 @@ he_return_code_t he_conn_start_pmtu_discovery(he_conn_t *conn) {
   }
 
   // Enter Base state
-  he_internal_pmtud_start_base_probing(conn);
-
-  return HE_SUCCESS;
+  return he_internal_pmtud_start_base_probing(conn);
 }
 
 uint16_t he_conn_get_effective_pmtu(he_conn_t *conn) {
diff --git a/src/he/pmtud.c b/src/he/pmtud.c
index edaaa6fb..1ef516f2 100644
--- a/src/he/pmtud.c
+++ b/src/he/pmtud.c
@@ -169,6 +169,9 @@ he_return_code_t he_internal_pmtud_start_base_probing(he_conn_t *conn) {
     case HE_PMTUD_STATE_SEARCH_COMPLETE:
       // Valid states
       break;
+    case HE_PMTUD_STATE_BASE:
+      // Already in base state, do nothing
+      return HE_SUCCESS;
     default:
       // Invalid states
       return HE_ERR_INVALID_CONN_STATE;