You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, a kernel adapter's extra_validity_checks() method only returns a boolean; but - it is not afforded a logger to print any error messages, so, essentially, the cause of failure remains opaque.
Assuming we continue to deny the adapter access to the logger, we should instead let it return something other than a boolean, e.g. an optional<std::string> or similar object, which, when empty, means success, otherwise is an error message to print. Alternatively we could not return anything from that method, and instead let it throw.
The text was updated successfully, but these errors were encountered:
At the moment, a kernel adapter's
extra_validity_checks()
method only returns a boolean; but - it is not afforded a logger to print any error messages, so, essentially, the cause of failure remains opaque.Assuming we continue to deny the adapter access to the logger, we should instead let it return something other than a boolean, e.g. an
optional<std::string>
or similar object, which, when empty, means success, otherwise is an error message to print. Alternatively we could not return anything from that method, and instead let it throw.The text was updated successfully, but these errors were encountered: