Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the extra_validity_checks return an error message #95

Open
eyalroz opened this issue Oct 16, 2024 · 0 comments
Open

Let the extra_validity_checks return an error message #95

eyalroz opened this issue Oct 16, 2024 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 16, 2024

At the moment, a kernel adapter's extra_validity_checks() method only returns a boolean; but - it is not afforded a logger to print any error messages, so, essentially, the cause of failure remains opaque.

Assuming we continue to deny the adapter access to the logger, we should instead let it return something other than a boolean, e.g. an optional<std::string> or similar object, which, when empty, means success, otherwise is an error message to print. Alternatively we could not return anything from that method, and instead let it throw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant