Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Change Image load event size info from logical size to pixel #45198

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes #45188. This fixes old arch. fabric fix may wait until #44918.

Changelog:

[IOS] [BREAKING] - Change Image load event size info from logical size to pixel

Test Plan:

Android/iOS return the same size .

    <Image
      style={{width: '100%', height: '100%'}}
      source={{
        uri: 'https://image-placeholder.com/images/actual-size/75x75.png',
      }}
      resizeMode={'cover'}
      onLoad={e => {
        console.log(
          `RNImage:${Platform.OS} load JPEG image from url`,
          e.nativeEvent,
        );
      }}
    />

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 27, 2024
@analysis-bot
Copy link

analysis-bot commented Jun 27, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,300,550 -15
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,497,351 -22
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ad3df84
Branch: main

@bohdanprog
Copy link

Hi @zhongwuzw :)
Let's replicate the same process in the new architecture, as it returns the same value as the old one.

@zhongwuzw
Copy link
Contributor Author

@cipolleschi Can you help to review it? :)

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting the fixes to the Old Arch.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 31, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 09995fc.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhongwuzw in 09995fc

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image component returns different data between iOS and Android in onLoad prop
6 participants