-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Change Image load event size info from logical size to pixel #45198
[iOS] Change Image load event size info from logical size to pixel #45198
Conversation
Base commit: ad3df84 |
Hi @zhongwuzw :) |
…/fix_image_load_evnet_inconsistent
…/fix_image_load_evnet_inconsistent
…/fix_image_load_evnet_inconsistent
@cipolleschi Can you help to review it? :) |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for backporting the fixes to the Old Arch.
@cipolleschi merged this pull request in 09995fc. |
This pull request was successfully merged by @zhongwuzw in 09995fc When will my fix make it into a release? | How to file a pick request? |
Summary:
Fixes #45188. This fixes old arch. fabric fix may wait until #44918.
Changelog:
[IOS] [BREAKING] - Change Image load event size info from logical size to pixel
Test Plan:
Android/iOS return the same size .