Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onRequestClosed not called in iOS pageSheet Modal #48030

Closed
jacolack opened this issue Nov 30, 2024 · 3 comments
Closed

onRequestClosed not called in iOS pageSheet Modal #48030

jacolack opened this issue Nov 30, 2024 · 3 comments
Labels
Component: Modal Needs: Version Info Platform: iOS iOS applications. Resolution: Fixed A PR that fixes this issue has been merged.

Comments

@jacolack
Copy link

jacolack commented Nov 30, 2024

Description

I have noticed a regression with the "New Architecture". In iOS, the pageSheet presentationStyle usually calls the onRequestClose callback when the user "swipes down" on the modal. This is no longer the case. I cannot therefore get the modal to even dismiss.

Steps to reproduce

Here is a snack: https://snack.expo.dev/@jacolack/modal?platform=ios

Simply set the "Expo" version to 52.0.0 to reproduce:

Tap the button to show the Modal.
Try to swipe down on the modal to hide it.
You cannot.

Set the "Expo" version to 51.0.0 to see that it does work, therefore this is a regression.

React Native Version

0.76.3

Affected Platforms

Runtime - iOS

Output of npx react-native info

N/A

Stacktrace or Logs

N/A

Reproducer

https://snack.expo.dev/@jacolack/modal?platform=ios

Screenshots and Videos

No response

@react-native-bot
Copy link
Collaborator

Warning

Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2.

@react-native-bot
Copy link
Collaborator

Warning

Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2.

@zhongwuzw
Copy link
Contributor

May fixed in #48037.

@migueldaipre migueldaipre added Resolution: PR Submitted A pull request with a fix has been provided. and removed Needs: Author Feedback labels Dec 2, 2024
robhogan pushed a commit that referenced this issue Dec 2, 2024
Summary:
Fixes #48030 .

## Changelog:

[IOS] [FIXED] - Fabric: Fixes Modal onRequestClose not called

Pull Request resolved: #48037

Test Plan: Repro please see  #48030.

Reviewed By: cortinico

Differential Revision: D66647232

Pulled By: cipolleschi

fbshipit-source-id: 773517dfe45f6f2e6348cda225e972fbac05edc2
@cortinico cortinico added Resolution: Fixed A PR that fixes this issue has been merged. and removed Resolution: PR Submitted A pull request with a fix has been provided. labels Dec 2, 2024
blakef pushed a commit that referenced this issue Dec 4, 2024
Summary:
Fixes #48030 .

[IOS] [FIXED] - Fabric: Fixes Modal onRequestClose not called

Pull Request resolved: #48037

Test Plan: Repro please see  #48030.

Reviewed By: cortinico

Differential Revision: D66647232

Pulled By: cipolleschi

fbshipit-source-id: 773517dfe45f6f2e6348cda225e972fbac05edc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Modal Needs: Version Info Platform: iOS iOS applications. Resolution: Fixed A PR that fixes this issue has been merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants