-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onRequestClosed not called in iOS pageSheet Modal #48030
Comments
Warning Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2. |
Warning Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2. |
May fixed in #48037. |
Summary: Fixes #48030 . ## Changelog: [IOS] [FIXED] - Fabric: Fixes Modal onRequestClose not called Pull Request resolved: #48037 Test Plan: Repro please see #48030. Reviewed By: cortinico Differential Revision: D66647232 Pulled By: cipolleschi fbshipit-source-id: 773517dfe45f6f2e6348cda225e972fbac05edc2
Description
I have noticed a regression with the "New Architecture". In iOS, the
pageSheet
presentationStyle
usually calls theonRequestClose
callback when the user "swipes down" on the modal. This is no longer the case. I cannot therefore get the modal to even dismiss.Steps to reproduce
Here is a snack: https://snack.expo.dev/@jacolack/modal?platform=ios
Simply set the "Expo" version to 52.0.0 to reproduce:
Tap the button to show the Modal.
Try to swipe down on the modal to hide it.
You cannot.
Set the "Expo" version to 51.0.0 to see that it does work, therefore this is a regression.
React Native Version
0.76.3
Affected Platforms
Runtime - iOS
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://snack.expo.dev/@jacolack/modal?platform=ios
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: