Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing yoga 0.0.0 podspec not using versions #48107

Closed
FrederickEngelhardt opened this issue Dec 5, 2024 · 5 comments
Closed

Installing yoga 0.0.0 podspec not using versions #48107

FrederickEngelhardt opened this issue Dec 5, 2024 · 5 comments
Labels
Newer Patch Available Resolution: Answered When the issue is resolved with a simple answer

Comments

@FrederickEngelhardt
Copy link

FrederickEngelhardt commented Dec 5, 2024

Description

Yogo podspec seems to be using 0.0.0 for its version when yoga 3.x.x is expected for react native 0.74.5 to 0.76.3. Is this expected for the podspec to have a 0.0.0 version?

Steps to reproduce

  1. Install a fresh clone of react native
  2. run pod install (with no pods installed otherwise delete the iOS/Pods folder).

React Native Version

0.76.3

Affected Platforms

Build - MacOS

Output of npx react-native info

N/a

Stacktrace or Logs

When running pod install I always see 


Installing Yoga (0.0.0)


### Reproducer

https://github.com/FrederickEngelhardt/react-native-issue-yoga-0-0-0/tree/main/ReproducerApp

### Screenshots and Videos

![20241204_180839](https://github.com/user-attachments/assets/a3950c20-9a87-4d78-9d4d-ce93294881fe)
@react-native-bot
Copy link
Collaborator

Tip

Newer version available: You are on a supported minor version, but it looks like there's a newer patch available - 0.74.6. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

@react-native-bot
Copy link
Collaborator

Tip

Newer version available: You are on a supported minor version, but it looks like there's a newer patch available - undefined. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

@NickGerleman
Copy link
Contributor

The Yoga version built as part of RN is versioned independently of OSS Yoga releases (its whatever commit matches in the monorepo). So it makes sense that it doesn't snap to Yoga public versions.

I'm not sure if there is any consequence of it not e.g. snapping to RN versions though (like if that has any potential to cause stale build or the like).

There was also some recent change to expose the headers from Yoga to full app, which may get weird if another library brings in public version of Yoga for its own use.

@cortinico
Copy link
Contributor

Closing as answered

@cortinico cortinico added Resolution: Answered When the issue is resolved with a simple answer and removed Needs: Triage 🔍 labels Dec 5, 2024
@FrederickEngelhardt
Copy link
Author

I guess the consequence could be when looking at the podfile if someone required yoga at a specific version it could pull in the public version on top of the react native version even if they were equivalent.

To me it just looks weird having a 0.0.0 version install. Makes sense though if this is not a direct copy of the public library.

Thanks for clarifying 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Newer Patch Available Resolution: Answered When the issue is resolved with a simple answer
Projects
None yet
Development

No branches or pull requests

4 participants