updated url.js #48355
updated url.js #48355
Conversation
|
Hi @suryaansh001! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
There was a problem hiding this comment.
Thanks for the PR. I've left some comments.
What is the purpose for the changes? Is there something you are unable to do that these changes unblock?
Please follow the PR guide here, that will help us to better review your proposal.
| @@ -23,15 +23,16 @@ if ( | |||
| // $FlowFixMe[unsafe-addition] | |||
| BLOB_URL_PREFIX = constants.BLOB_URI_SCHEME + ':'; | |||
| if (typeof constants.BLOB_URI_HOST === 'string') { | |||
| BLOB_URL_PREFIX += `//${constants.BLOB_URI_HOST}/`; | |||
| BLOB_URL_PREFIX += //${constants.BLOB_URI_HOST}/; | |||
There was a problem hiding this comment.
Why was this string template removed?
| try { | ||
| this._parsedUrl = new window.URL(this._url); | ||
| } catch (error) { | ||
| throw new Error(Invalid URL: ${this._url}); |
There was a problem hiding this comment.
What's the purpose of rethrowing an error here, is the exception new URL already throws insufficient? https://developer.mozilla.org/en-US/docs/Web/API/URL/URL#exceptions
| @@ -161,13 +180,8 @@ export class URL { | |||
| if (this._searchParamsInstance === null) { | |||
| return this._url; | |||
| } | |||
| // $FlowFixMe[incompatible-use] | |||
| } | ||
| } | ||
|
|
||
| /* | ||
| * To allow Blobs be accessed via `content://` URIs, |
There was a problem hiding this comment.
I think you may have find&replace removed "`"
Summary:
Implementing the url accessors -host ,hostname etc also changing from searchParams to _parsedurl
Changelog:
Test Plan: