Remove existing logs and warnings from tests #48391
Closed
+83
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67602299 |
|
This pull request was exported from Phabricator. Differential Revision: D67602299 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 27, 2024
Summary: Pull Request resolved: facebook#48391 Changelog: [internal] When we enabled log streaming in Fantom, we saw a lot of logs that we were previously not forwarding (console.error, console.warn) in existing tests. This removes all the warnings and errors from those tests. Differential Revision: D67602299
rubennorte
force-pushed
the
export-D67602299
branch
from
030be52 to
70a4c05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67602299 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 1, 2025
Summary: Pull Request resolved: facebook#48391 Changelog: [internal] When we enabled log streaming in Fantom, we saw a lot of logs that we were previously not forwarding (console.error, console.warn) in existing tests. This removes all the warnings and errors from those tests. Reviewed By: rshest Differential Revision: D67602299
rubennorte
force-pushed
the
export-D67602299
branch
from
70a4c05 to
bd53327
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 2, 2025
Summary: Pull Request resolved: facebook#48391 Changelog: [internal] When we enabled log streaming in Fantom, we saw a lot of logs that we were previously not forwarding (console.error, console.warn) in existing tests. This removes all the warnings and errors from those tests. Reviewed By: rshest Differential Revision: D67602299
rubennorte
force-pushed
the
export-D67602299
branch
from
bd53327 to
5cedab6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67602299 |
Differential Revision: D67549203
Differential Revision: D67759729
|
This pull request was exported from Phabricator. Differential Revision: D67602299 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Pull Request resolved: facebook#48391 Changelog: [internal] When we enabled log streaming in Fantom, we saw a lot of logs that we were previously not forwarding (console.error, console.warn) in existing tests. This removes all the warnings and errors from those tests. Reviewed By: rshest Differential Revision: D67602299
rubennorte
force-pushed
the
export-D67602299
branch
from
5cedab6 to
fa755d8
Compare
Summary: Pull Request resolved: facebook#48391 Changelog: [internal] When we enabled log streaming in Fantom, we saw a lot of logs that we were previously not forwarding (console.error, console.warn) in existing tests. This removes all the warnings and errors from those tests. Reviewed By: rshest Differential Revision: D67602299
rubennorte
force-pushed
the
export-D67602299
branch
from
fa755d8 to
a741e23
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67602299 |
|
This pull request has been merged in fb3b87c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
When we enabled log streaming in Fantom, we saw a lot of logs that we were previously not forwarding (console.error, console.warn) in existing tests.
This removes all the warnings and errors from those tests.
Differential Revision: D67602299