Implemented URL Methods #48406
Closed
Implemented URL Methods #48406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cipolleschi @cortinico Apologies for tagging but Can you check if this can be merged |
|
@riteshshukla04 Thanks for the PR, but there is already another PR that is doing something similar: #48333. We try to give priority to PRs that arrives first. Feel free to comment and review the other PR as well to make sure that also all your changes are included. |
|
Thanks @cipolleschi . I didnt see that PR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented URL accessors . Fixes #45030
The methods output are identical to outputs of window.url .
Changelog:
[General][Added] URL accessors for unimplemented Methods
Test Plan:
Tested with URL :- 'https://example.com:8080/path?query=1#hash'