tag. Either remove it ' +
'from the element, or pass a string or number value to keep it ' +
'in the DOM. For details, see https://react.dev/link/attribute-behavior \n' +
' in div (at **)',
- );
+ ]);
});
it('removes functions and warns', async () => {
- await expect(() =>
- testUnknownAttributeRemoval(function someFunction() {}),
- ).toErrorDev(
+ await testUnknownAttributeRemoval(function someFunction() {});
+ assertConsoleErrorDev([
'Invalid value for prop `unknown` on
tag. Either remove ' +
'it from the element, or pass a string or number value to ' +
'keep it in the DOM. For details, see ' +
'https://react.dev/link/attribute-behavior \n' +
' in div (at **)',
- );
+ ]);
});
it('allows camelCase unknown attributes and warns', async () => {
const el = document.createElement('div');
- await expect(async () => {
- const root = ReactDOMClient.createRoot(el);
+ const root = ReactDOMClient.createRoot(el);
- await act(() => {
- root.render(
);
- });
- }).toErrorDev(
+ await act(() => {
+ root.render(
);
+ });
+ assertConsoleErrorDev([
'React does not recognize the `helloWorld` prop on a DOM element. ' +
'If you intentionally want it to appear in the DOM as a custom ' +
'attribute, spell it as lowercase `helloworld` instead. ' +
'If you accidentally passed it from a parent component, remove ' +
'it from the DOM element.\n' +
' in div (at **)',
- );
+ ]);
expect(el.firstChild.getAttribute('helloworld')).toBe('something');
});
diff --git a/packages/react-dom/src/__tests__/ReactDeprecationWarnings-test.js b/packages/react-dom/src/__tests__/ReactDeprecationWarnings-test.js
index e0022dd99004b..a617770cf5f3b 100644
--- a/packages/react-dom/src/__tests__/ReactDeprecationWarnings-test.js
+++ b/packages/react-dom/src/__tests__/ReactDeprecationWarnings-test.js
@@ -12,6 +12,7 @@
let React;
let ReactNoop;
let waitForAll;
+let assertConsoleErrorDev;
describe('ReactDeprecationWarnings', () => {
beforeEach(() => {
@@ -20,6 +21,7 @@ describe('ReactDeprecationWarnings', () => {
ReactNoop = require('react-noop-renderer');
const InternalTestUtils = require('internal-test-utils');
waitForAll = InternalTestUtils.waitForAll;
+ assertConsoleErrorDev = InternalTestUtils.assertConsoleErrorDev;
});
// @gate !disableDefaultPropsExceptForClasses || !__DEV__
@@ -33,11 +35,13 @@ describe('ReactDeprecationWarnings', () => {
};
ReactNoop.render(
);
- await expect(async () => await waitForAll([])).toErrorDev(
+ await waitForAll([]);
+ assertConsoleErrorDev([
'FunctionalComponent: Support for defaultProps ' +
'will be removed from function components in a future major ' +
- 'release. Use JavaScript default parameters instead.',
- );
+ 'release. Use JavaScript default parameters instead.\n' +
+ ' in FunctionalComponent (at **)',
+ ]);
});
// @gate !disableDefaultPropsExceptForClasses || !__DEV__
@@ -55,10 +59,12 @@ describe('ReactDeprecationWarnings', () => {
,
);
- await expect(async () => await waitForAll([])).toErrorDev(
+ await waitForAll([]);
+ assertConsoleErrorDev([
'FunctionalComponent: Support for defaultProps ' +
'will be removed from memo components in a future major ' +
- 'release. Use JavaScript default parameters instead.',
- );
+ 'release. Use JavaScript default parameters instead.\n' +
+ ' in div (at **)',
+ ]);
});
});
diff --git a/packages/react-dom/src/__tests__/findDOMNodeFB-test.js b/packages/react-dom/src/__tests__/findDOMNodeFB-test.js
index 417ae0c40e7f8..28212c0d5cf82 100644
--- a/packages/react-dom/src/__tests__/findDOMNodeFB-test.js
+++ b/packages/react-dom/src/__tests__/findDOMNodeFB-test.js
@@ -12,6 +12,8 @@
const React = require('react');
const ReactDOM = require('react-dom');
const StrictMode = React.StrictMode;
+const assertConsoleErrorDev =
+ require('internal-test-utils').assertConsoleErrorDev;
describe('findDOMNode', () => {
// @gate www && classic
@@ -128,8 +130,8 @@ describe('findDOMNode', () => {
container,
);
- let match;
- expect(() => (match = ReactDOM.findDOMNode(parent))).toErrorDev([
+ const match = ReactDOM.findDOMNode(parent);
+ assertConsoleErrorDev([
'findDOMNode is deprecated in StrictMode. ' +
'findDOMNode was passed an instance of ContainsStrictModeChild which renders StrictMode children. ' +
'Instead, add a ref directly to the element you want to reference. ' +
@@ -161,8 +163,8 @@ describe('findDOMNode', () => {
container,
);
- let match;
- expect(() => (match = ReactDOM.findDOMNode(parent))).toErrorDev([
+ const match = ReactDOM.findDOMNode(parent);
+ assertConsoleErrorDev([
'findDOMNode is deprecated in StrictMode. ' +
'findDOMNode was passed an instance of IsInStrictMode which is inside StrictMode. ' +
'Instead, add a ref directly to the element you want to reference. ' +
diff --git a/packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js b/packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js
index 76dea3e732632..67d29fd33efdc 100644
--- a/packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js
+++ b/packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js
@@ -87,7 +87,7 @@ module.exports = function (initModules) {
console.error.mockClear();
} else {
// TODO: Rewrite tests that use this helper to enumerate expected errors.
- // This will enable the helper to use the .toErrorDev() matcher instead of spying.
+ // This will enable the helper to use the assertConsoleErrorDev instead of spying.
spyOnDev(console, 'error').mockImplementation(() => {});
}