Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a locale extension if one is manually specified #618

Open
2 tasks done
bbhtt opened this issue Sep 25, 2024 · 0 comments
Open
2 tasks done

Don't create a locale extension if one is manually specified #618

bbhtt opened this issue Sep 25, 2024 · 0 comments

Comments

@bbhtt
Copy link
Contributor

bbhtt commented Sep 25, 2024

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.4.4

Flatpak version

1.15.10

How to reproduce

When a locale extension is manually specified through add-extensions with the same base ID as the app, Flatpak Builder should skip creating it's own locale extension.

Having both causes duplicate groups to be written in the metadata file.

app-id: org.example.test
runtime: org.freedesktop.Platform
runtime-version: '24.08'
sdk: org.freedesktop.Sdk
add-extensions:
 org.example.test.Locale:
  directory: share/runtime/locale
  autodelete: true
  locale-subset: true
cleanup-commands:
  - mkdir -p ${FLATPAK_DEST}/share/runtime/locale

causes the metadata to be:

[Application]
name=org.example.test
runtime=org.freedesktop.Platform/x86_64/24.08
sdk=org.freedesktop.Sdk/x86_64/24.08

[Extension org.example.test.Locale]
directory=share/runtime/locale
autodelete=true
locale-subset=true

[Extension org.example.test.Locale]
directory=share/runtime/locale
autodelete=true
locale-subset=true

[Build]
built-extensions=org.example.test.Locale;

which has two duplicate groups.

Expected Behavior

Disable Locale extension creation and don't write duplicate groups

Actual Behavior

Writes duplicate groups in metadata

Additional Information

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant