-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add insertedDate and lastModifiedDate to attributes and document attributes #286
Comments
@reganwolfrom Which API endpoints are you referring to? |
@mfriesen I see that insertedDate now exists on GET /documents/{documentId}/attributes and GET /documents/{documentId}/attributes/{attributeKey}, but would like lastModifiedDate, if possible. GET /attributes does not have an insertedDate or lastModifiedDate (though possibly lastModifiedDate makes no sense, and this is probably not as important as document attributes. |
LastModifiedDate is tricky because the LastModifiedDate is tied to the AttributeKey + AttributeValue. So on GET /documents/{documentId}/attributes/{attributeKey} when stringValue(s) is returned there's no way to say value1 was lastmodified on date X and value2 was lastmodified on date Y. So technically InsertedDate could be incorrect but typically values are inserted at the same time and this was the compromise made |
@mfriesen you mean that the compromise is to only provide insertedDate, since the assumption is that lastModifiedDate is usually the same date, but it's not always possible to validate that or provide an alternate value? |
Document Attributes are saved as: If you added last modified date The API returns Last modified date on the attribute is tricky. If you update , do you update the last modified date for ALL attributes? |
@mfriesen I think there are two questions here:
I think the first question is what matters, vs. API responses, which could always have additional properties provided as an array of objects, but obviously that shouldn't remove the lovely array of strings (or numbers) you get now. |
It appears that attributes and document attributes do not have insertedDate and lastModifiedDate properties; ideally, these would be included with the resources themselves directly (DynamoDB and API).
The text was updated successfully, but these errors were encountered: