Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] GH-Actions for static code analysis #186

Closed
opxdelwin opened this issue Feb 24, 2024 · 4 comments · Fixed by #188
Closed

[feat] GH-Actions for static code analysis #186

opxdelwin opened this issue Feb 24, 2024 · 4 comments · Fixed by #188
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@opxdelwin
Copy link
Contributor

opxdelwin commented Feb 24, 2024

Tell us about the task you want to perform and are unable to do so because the feature is not available
Enable GitHub Actions for this project to automate static Flutter Code Analysis

Describe the solution/feature you'd like us to add
Building appropriate pipeline that'd test relevant commits for code analysis issue.

Any other feedback you would like to provide regarding the site
A comprehensive discussion must be carried out with the community to fix existing analysis issue, whose fix would be addressed in upcoming PRs. Here are few highlighted analysis issue, for which maintainers may suggest appropriate actions.

See Detailed Table
Serial No. Status Issue Location Suggested Action
1.
Invalid option specified for 'enable-experiment': Flag "records" is no longer required. analysis_options.yaml Remove
2.
The parameter type of '==' operators should be non-nullable. Try using a non-nullable type. lib\models\form_data_model.freezed.dart Add Lint Ignore
3.
The parameter type of '==' operators should be non-nullable. Try using a non-nullable type. lib\models\name_value_model.freezed.dart
4.
The value of the local variable 'length' isn't used. Try removing the variable or using it. lib\screens\home_page\editor_pane\details_card\request_pane\request_headers.dart Remove unused vars
5.
The value of the local variable 'length' isn't used. Try removing the variable or using it. lib\screens\home_page\editor_pane\details_card\request_pane\request_params.dart Remove unused vars
6.
This method overrides a method annotated as '@mustCallSuper' in 'State', but doesn't invoke the overridden method. lib\widgets\headerfield.dart Add Annotation
7.
This method overrides a method annotated as '@mustCallSuper' in 'State', but doesn't invoke the overridden method. lib\widgets\json_previewer.dart Add Annotation
8.
Unused import: 'package:apidash/main.dart'. Try removing the import directive. test\widget_test.dart For Code Coverage, Fixed in #158
9.
Unused import: 'package:flutter/material.dart'. Try removing the import directive. test\widgets\markdown_test.dart Remove imports
10.
The variable name '_$$_NameValueModelFromJson' isn't a lowerCamelCase identifier. Try changing the name to follow the lowerCamelCase style. (x2) lib\models\name_value_model.g.dart Generated Code, add lint ignore.
11.
TODO (x4) - Wont break analysis, but better to fix to prevent tech-debt

Once we're at par with above mentioned issues, I'll fix them within the main Actions PR itself.

Awaiting everyone's valuable feedback.

@opxdelwin opxdelwin added the enhancement New feature or request label Feb 24, 2024
@opxdelwin
Copy link
Contributor Author

@ashitaprasad @animator Please share your feedback with reference to serial number..

@animator
Copy link
Member

It will be added to the roadmap but currently it is not a priority as we have other major features to work on.

@opxdelwin
Copy link
Contributor Author

What if I already have a PR ready :) ?

@ashitaprasad
Copy link
Member

@opxdelwin Then you can send across a PR. We'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants