Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: suggested improvements for protocol flow diagram #51

Open
5 tasks
lumaier opened this issue Jul 5, 2024 · 0 comments
Open
5 tasks

README: suggested improvements for protocol flow diagram #51

lumaier opened this issue Jul 5, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@lumaier
Copy link
Contributor

lumaier commented Jul 5, 2024

Some things I think are not really clear or wrong in the flow diagram (even tough it is really good overall):

  • Right at the end where message_ciphertext is decrypted at the source, the order of the concatenated messages is different to how the journalist encrypted them ($reply || JC_{PK} ||{}^mJE_{PK}$)
  • It looks like as if the server initiates the "fetch" operation (i.e., a "fetch" message sent to the server is missing IMO)
  • When looking at the "read" operation at the journalist's side, it isn't really clear how $message\_id$ is derived (although one can guess that it is "the one" which was successfully decrypted-flow diagram doesn't cover the case when multiple ids are decrypted).
  • The preceeding superscript ${}^{0-i}JE_{SK}$ makes sense in my opinion if you mean ${}^0JE_{SK},\dots,{}^iJE_{SK}$. Inside a "for" loop I would go for an index-based notation such as: $\text{for }j = 0,\dots,i: {}^jJE_{SK} = Gen()$
  • I would add a comment in the flow diagram that a journalist tries all unused ephemeral keys ${}^iJE_{SK}$ when decrypting a ciphertext
@lsd-cat lsd-cat added the documentation Improvements or additions to documentation label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants