Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether Mocha::ClassMethods::AnyInstance should be overriding #respond_to? #713

Open
floehopper opened this issue Jan 1, 2025 · 0 comments
Open

Investigate whether Mocha::ClassMethods::AnyInstance should be overriding #respond_to? #713

floehopper opened this issue Jan 1, 2025 · 0 comments
Labels
quality

Comments

@floehopper
Copy link
Member

Maybe this class should define #respond_to_missing? instead...?

mocha/lib/mocha/class_methods.rb

Lines 29 to 31 in 4cda7d6

def respond_to?(symbol, include_all = false)
@stubba_object.allocate.respond_to?(symbol.to_sym, include_all)
end

floehopper added a commit that referenced this issue Jan 1, 2025
@floehopper
Allow some core Ruby methods to be overridden
e423977 
These core Ruby method signatures violate
the `Style/OptionalBooleanParameter` cop and a bunch of tests
legitimately override them.

The one exception is `Mocha::ClassMethods::AnyInstance#respond_to?`
which is in library code. I've opened an issue (#713) to investigate
whether that class should define `#respond_to_missing?` instead.

Ideally I would've configured the extra `AllowedMethods` to only apply
to the tests, but I couldn't find a simple way to do that with the
rubocop configuration. It might be worth extracting a separate rubocop
configuration for the tests...?
floehopper added a commit that referenced this issue Jan 1, 2025
@floehopper
Allow some core Ruby methods to be overridden
33e373c 
These core Ruby method signatures violate
the `Style/OptionalBooleanParameter` cop and a bunch of tests
legitimately override them.

The one exception is `Mocha::ClassMethods::AnyInstance#respond_to?`
which is in library code. I've opened an issue (#713) to investigate
whether that class should define `#respond_to_missing?` instead.

Ideally I would've configured the extra `AllowedMethods` to only apply
to the tests, but I couldn't find a simple way to do that with the
rubocop configuration. It might be worth extracting a separate rubocop
configuration for the tests...?
floehopper added a commit that referenced this issue Jan 1, 2025
@floehopper
Allow some core Ruby methods to be overridden
fddebc3 
These core Ruby method signatures violate
the `Style/OptionalBooleanParameter` cop and a bunch of tests
legitimately override them.

The one exception is `Mocha::ClassMethods::AnyInstance#respond_to?`
which is in library code. I've opened an issue (#713) to investigate
whether that class should define `#respond_to_missing?` instead.

Ideally I would've configured the extra `AllowedMethods` to only apply
to the tests, but I couldn't find a simple way to do that with the
rubocop configuration. It might be worth extracting a separate rubocop
configuration for the tests...?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@floehopper