helm CRD invalid due to templating variables

[warmfusion]

(Copied from spotahome#700 (comment) )

Expected behaviour

A redis operator has to be installed successfully.

Actual behaviour

Fails out of the box.

Command
helm install redis-operator redis-operator/redis-operator

fails with the following error:

PS C:\Users\user\Documents\projects\p1\cicd> helm install redis-operator redis-operator/redis-operator
Error: INSTALLATION FAILED: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

Steps to reproduce the behaviour

Execute helm install redis-operator redis-operator/redis-operator

Environment

EKS cluster platform version eks.7
K8s version - 1.29

---

Investigations in spotahome#700 shows that the issue relates to the introduction of template variables in the CRD which helm (by design) does not render.

As a consequence, the CRD output is invalid yaml.

The following lines should be removed from the CRD definition;

https://github.com/freshworks/redis-operator/blob/master/charts/redisoperator/crds/databases.spotahome.com_redisfailovers.yaml#L7-L9

[warmfusion]

Helm explicitly does not support templating in CRD resources.

https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#:~:text=This%20is%20also%20the%20reason%20behind%20removing%20templating%20support%20from%20CRDs.

[pascaliske]

Hi,

We also faced this issue with the latest release. So I created a PR to fix this: #16.

Hopefully we can get this merged & released soon after the holidays. 🙂

Merry Christmas! 🎅🏻