Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not respecting 'Allow force pushing' setting #5764

Open
stevelw opened this issue Dec 6, 2024 · 1 comment
Open

Not respecting 'Allow force pushing' setting #5764

stevelw opened this issue Dec 6, 2024 · 1 comment
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions UI Any broken visuals like layouts, colors etc.

Comments

@stevelw
Copy link

stevelw commented Dec 6, 2024

I've not attempted to reproduce, but the current scenario that has encountered this:

  1. 'Allow force pushing' turned off for open project
  2. Remote branch applied with open PR, fully pushed.
  3. Dependent branch applied above that PR
  4. Uncommitted change (file not hunk) dragged from 'changed files' to latest commit in branch from step 2.
  5. 'Force push' button appears at bottom
  6. When clicked, force push happens, confirmed in GitHub PR history

Expected behavior:

User shouldn't even be able to drag changes onto a pushed commit if 'allow force pushing' is disabled.

@Byron Byron added bug Something isn't working UI Any broken visuals like layouts, colors etc. 🎉reproduced🎉 The issue could be reproduced by following the instructions labels Dec 7, 2024
@Byron
Copy link
Collaborator

Byron commented Dec 7, 2024

Thanks a lot for reporting!

It does indeed seem like the setting has no effect.

Screen.Recording.2024-12-07.at.07.38.25.mov

CC @estib-vega

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions UI Any broken visuals like layouts, colors etc.
Projects
None yet
Development

No branches or pull requests

2 participants