Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not close the app/minimize on full-screen mode #5869

Open
muhghazaliakbar opened this issue Dec 23, 2024 · 4 comments
Open

Can not close the app/minimize on full-screen mode #5869

muhghazaliakbar opened this issue Dec 23, 2024 · 4 comments
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions

Comments

@muhghazaliakbar
Copy link

Version

0.14.4

Operating System

macOS

Distribution Method

dmg (Apple Silicon)

Describe the issue

The application can not be closed when you are in full-screen mode. Here's the attached video about the issue

Gitbutler.close.app.issue.on.full-screen.mp4

How to reproduce

Just go to full-screen mode and try to close the app by clicking the red button on the top left

Expected behavior

No response

Relevant log output

No response

@muhghazaliakbar muhghazaliakbar added the bug Something isn't working label Dec 23, 2024
@Byron Byron added 🎉reproduced🎉 The issue could be reproduced by following the instructions UI Any broken visuals like layouts, colors etc. labels Dec 24, 2024
@Byron
Copy link
Collaborator

Byron commented Dec 24, 2024

Thanks a lot for reporting!

This issue was easily reproducible as well. On top of that, I noticed that after clicking the close button, to focus seems to shift onto another application, so there seems to be some side-effect.

I'd think that this related to the special behaviour on MacOS that only closes the WIndow instead of shutting down the application. Window-closing doesn't seem to work when maximised.

@muhghazaliakbar
Copy link
Author

muhghazaliakbar commented Dec 24, 2024

Thanks a lot for reporting!

This issue was easily reproducible as well. On top of that, I noticed that after clicking the close button, to focus seems to shift onto another application, so there seems to be some side-effect.

I'd think that this related to the special behaviour on MacOS that only closes the WIndow instead of shutting down the application. Window-closing doesn't seem to work when maximised.

It doesn't matter the application is closed or just minimized by MacOS, but it should be working, right?

@PavelLaptev PavelLaptev removed the UI Any broken visuals like layouts, colors etc. label Dec 24, 2024
@PavelLaptev
Copy link
Contributor

Sorry, @Byron, I removed the "UI" tag. To me, this is not a UI issue. Traffic lights are a native thing, visually not broken, but they don’t work.

@Byron
Copy link
Collaborator

Byron commented Dec 25, 2024

@PavelLaptev Apologies, I will keep that in mind.

It doesn't matter the application is closed or just minimized by MacOS, but it should be working, right?

Definitely! I merely dumped everything I know about it as to help others or myself in future.

@muhghazaliakbar muhghazaliakbar changed the title Can no close the app on full-screen mode Can not close the app on full-screen mode Dec 25, 2024
@muhghazaliakbar muhghazaliakbar changed the title Can not close the app on full-screen mode Can not close the app/minimize on full-screen mode Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions
Projects
None yet
Development

No branches or pull requests

3 participants