From e33c5706f8a6b486e171b0b3264e949c67f813f9 Mon Sep 17 00:00:00 2001 From: Sid Shankar Date: Thu, 11 Apr 2024 12:59:41 -0400 Subject: [PATCH] Modifies check for py launcher This commit modifies the check for the "py" launcher on windows. We now look for the launcher only if the python_executable_name extractor option is not specified. --- python/extractor/buildtools/version.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/python/extractor/buildtools/version.py b/python/extractor/buildtools/version.py index e6f685a64b1c..9098ee5ab209 100644 --- a/python/extractor/buildtools/version.py +++ b/python/extractor/buildtools/version.py @@ -18,12 +18,12 @@ WIN = sys.platform == "win32" - -if WIN: +if WIN and "CODEQL_EXTRACTOR_PYTHON_OPTION_PYTHON_EXECUTABLE_NAME" not in os.environ: # installing `py` launcher is optional when installing Python on windows, so it's # possible that the user did not install it, see # https://github.com/github/codeql-cli-binaries/issues/125#issuecomment-1157429430 - # so we check whether it has been installed. Newer versions have a `--list` option, + # so we check whether it has been installed, and we check only if the "python_executable_name" + # extractor option has not been specified. Newer versions have a `--list` option, # but that has only been mentioned in the docs since 3.9, so to not risk it not # working on potential older versions, we'll just use `py --version` which forwards # the `--version` argument to the default python executable.