Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asd #27

Closed
wants to merge 3 commits into from
Closed

asd #27

wants to merge 3 commits into from

Conversation

afwn90cj93201nixr2e1re
Copy link

Fixes #15

Copy link
Author

@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@keithamus
Copy link
Member

Sadly event.code will not work in this instance because alternative layouts such as Dvorak misreport their key. For example in Dvorak, pushing x will result in KeyB while pushing b will result in KeyB also.

I'll close this PR as it will introduce new bugs which we've already fixed prior. I welcome new ideas to fix this though!

@keithamus keithamus closed this Mar 30, 2020
@afwn90cj93201nixr2e1re
Copy link
Author

Em, is that really problem? It's their implementation problem's.

@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re deleted the patch-1 branch March 30, 2020 22:52
@keithamus
Copy link
Member

I am not referring to an implementation, but the underlying mechanics of event.code - it specifies the keyboard character which means it does not support switching layouts. The same is true of any alternate layout, not just specific ones. We made a switch from event.code to event.key to solve precisely this bug.

@afwn90cj93201nixr2e1re
Copy link
Author

btw .code is newer than key, so, i think key gonna be deprecated soon.

@afwn90cj93201nixr2e1re
Copy link
Author

Maybe we should just make detector?

@keithamus
Copy link
Member

Happy to explore ideas. I'm not sure how a detector could be made. You could compare code and key, and if there's a discrepency, then... I'm not sure how you'd resolve that?

@afwn90cj93201nixr2e1re
Copy link
Author

Yep, as u suggested. Just try to emulate key press, and check what's going on.

https://github.com/ahtcx/layoutline
btw it's also just piece of shit, u r right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotkeys don't work on Windows with non en-us keyboard layout
2 participants