Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export containerd's metrics #382

Open
utam0k opened this issue Nov 16, 2022 · 1 comment
Open

Export containerd's metrics #382

utam0k opened this issue Nov 16, 2022 · 1 comment

Comments

@utam0k
Copy link
Contributor

utam0k commented Nov 16, 2022

Is your feature request related to a problem? Please describe

This PR will make containerd export metrics at 127.0.0.1:9000/v1/metrics. I would like to be able to have prometheus retrieve this.
https://github.com/gitpod-io/gitpod-packer-gcp-image/pull/190

Describe the behaviour you'd like

We can see container_start metrics on Grafana.
https://github.com/containerd/containerd/blob/9afc778b7354d4b89f02daebcd56eaf85b96c98d/pkg/cri/server/metrics.go#L55

Describe alternatives you've considered

Additional context

This feature request came from
https://www.notion.so/Why-does-gen75-s-workspace-start-slower-be5fc7fdb86c4ea7b964e1cb9cab4654?d=01eeccdc20b9481e98ccdc76781a6463#7c0c8799aa4849a88d3b3c813e7ed2c3

@kylos101
Copy link
Contributor

@ArthurSens We're currently working in https://github.com/gitpod-io/ops/pull/6775, such that we expose containerd metrics via a kube-rbac-proxy daemonset, and ServiceMonitor (which, I think will Prometheus what to scrape).

I'm not sure if we need this issue for the observability repo, things appear to be contained in the ops repo via https://github.com/gitpod-io/ops/pull/6775.

Does that sound right? Is there work to do in the observability repo that I am missing? If no, perhaps we can close this issue as Won't Fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants