-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Temporary mat files at the end of run_SINGE_GLG_test.sh #61
Comments
The end of currently has Line 92 in 9c59a1e
Is that line not working? |
I think there's a case to be made to clean up if for any reason a job fails, not reaching this point in MATLAB. |
I agree that we should still delete temporary files even if a job fails. However, is it possible to do that in a way that also cleans up the temporary files if the job fails when run through MATLAB instead of the shell script? For example, can we catch errors in this function and delete the temporary file if there is an error? |
Do we also need to delete the file Lines 76 to 86 in 9c59a1e
|
Issue: Depending on the data size, large TempMat*.mat files are created during SINGE_GLG_Test, which could overrun user's storage budget leading to subsequent jobs being held.
Fix: We should include the line
eval "rm Temp*.mat"
near the end of run_SINGE_GLG_Test.sh
EDIT: The rm should be more targeted, especially if the storage is shared, with only
Temp_<ID>.mat
to be deleted.The text was updated successfully, but these errors were encountered: