feat: don't update cache when there is an error

Signed-off-by: Matt Gleich <[email protected]>
gleich · Dec 7, 2024 · 9210e48 · 9210e48
1 parent ba261d2
commit 9210e48
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/internal/cache/cache.go b/internal/cache/cache.go
@@ -104,8 +104,10 @@ func (c *Cache[T]) StartPeriodicUpdate(updateFunc func() (T, error), interval ti
 	defer ticker.Stop()
 	for range ticker.C {
 		data, err := updateFunc()
-		if err != nil && !errors.Is(err, apis.WarningError) {
-			lumber.Error(err, "updating", c.name, "cache failed")
+		if err != nil {
+			if !errors.Is(err, apis.WarningError) {
+				lumber.Error(err, "updating", c.name, "cache failed")
+			}
 		} else {
 			c.Update(data)
 		}