feat: prevent accidental invalid paths

Signed-off-by: Matt Gleich <[email protected]>
gleich · Dec 2, 2024 · ba5819d · ba5819d
1 parent 8d9dbbf
commit ba5819d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/internal/apis/applemusic/api.go b/internal/apis/applemusic/api.go
@@ -3,6 +3,7 @@ package applemusic
 import (
 	"fmt"
 	"net/http"
+	"strings"
 
 	"github.com/gleich/lcp-v2/internal/apis"
 	"github.com/gleich/lcp-v2/internal/secrets"
@@ -11,7 +12,11 @@ import (
 
 func sendAppleMusicAPIRequest[T any](path string) (T, error) {
 	var zeroValue T
-	req, err := http.NewRequest("GET", fmt.Sprintf("https://api.music.apple.com%s", path), nil)
+	req, err := http.NewRequest(
+		"GET",
+		fmt.Sprintf("https://api.music.apple.com/%s", strings.TrimLeft(path, "/")),
+		nil,
+	)
 	if err != nil {
 		lumber.Error(err, "failed to create request")
 		return zeroValue, err

diff --git a/internal/apis/strava/api.go b/internal/apis/strava/api.go
@@ -3,6 +3,7 @@ package strava
 import (
 	"fmt"
 	"net/http"
+	"strings"
 
 	"github.com/gleich/lcp-v2/internal/apis"
 	"github.com/gleich/lumber/v3"
@@ -11,7 +12,11 @@ import (
 func sendStravaAPIRequest[T any](path string, tokens tokens) (T, error) {
 	var zeroValue T
 
-	req, err := http.NewRequest("GET", fmt.Sprintf("https://www.strava.com/%s", path), nil)
+	req, err := http.NewRequest(
+		"GET",
+		fmt.Sprintf("https://www.strava.com/%s", strings.TrimLeft(path, "/")),
+		nil,
+	)
 	if err != nil {
 		lumber.Error(err, "failed to create request")
 		return zeroValue, err