Bad equation argument for gl.ClipPlane

[tildeleb]

For the function ClipPlane the equation argument doesn't look like it was translated correctly from C.

It is:

    //void glClipPlane (GLenum plane, const float64 *equation)
    func ClipPlane(plane GLenum, equation *float64) {
        C.glClipPlane(C.GLenum(plane), (*C.GLdouble)(equation))
}

I would prefer to change it to:

    //void glClipPlane (GLenum plane, const float64 *equation)
    func ClipPlane(plane GLenum, equation []float64) {
        C.glClipPlane(C.GLenum(plane), (*C.GLdouble)(&equation[0))

which is similar to current Materialfv call but I could also change it to use a type of similar to the one used for:

//void glNormal3dv (const float64 *v)
func Normal3dv(v *[3]float64) {
    C.glNormal3dv((*C.GLdouble)(&v[0]))
}

I think it would be best if go-gl was consistant with typing. I much prefer the slice over the array. Anyone have any opinions on which type would be best?

Over the long term how do we resolve differences in typing?

leb

[UserAB1236872]

This is definitely wrong, since it wants 4 floats.

The slice is definitely better than an array. The reason is that it's trivial to go from an array to a slice (array[:]) but difficult to go from a slice to an array (requires unsafe or a copy). The only question is whether we want to bounds check the slice, I'd prefer not, but it's not a huge deal either way.

[UserAB1236872]

Oh, I see this issue was already mentioned:

go-gl/gl#154

[pwaller]

Let's close this as a dupe of #154 and continue discussion there.