Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filename to call back function #55

Open
gemal opened this issue Jul 8, 2016 · 2 comments
Open

add filename to call back function #55

gemal opened this issue Jul 8, 2016 · 2 comments

Comments

@gemal
Copy link

gemal commented Jul 8, 2016

wouldn't it be possible to change:
new ExifImage({ image : 'myImage.jpg' }, function (error, exifData) {
into
new ExifImage({ image : 'myImage.jpg' }, function (error, exifData, filename) {

so I inside the callback function can see which file is haveing the exifData

@oeuillot
Copy link
Collaborator

Hello @gemal ,
The third parameter is already used and will contain the path ! (if you specify the path)
I don't understand your problem :-p

Regards

@PaulThompson
Copy link

This is an omission from the documentation - from the source it appears the callback is already calling out with 1 or 3 arguments:
callback(error);
or
callback(null, exifData, ops.image);

In fact this caused a bug for me because bluebird 2.x promisify reinterprets multiple callback arguments into an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants