From 5e6559257037487ca0cd2fb1feeef2c538ca4b46 Mon Sep 17 00:00:00 2001 From: Carlos O'Ryan Date: Wed, 3 Jul 2024 03:07:51 +0000 Subject: [PATCH] Remove debug logs --- .../cloud/storage/internal/retry_object_read_source.cc | 9 --------- 1 file changed, 9 deletions(-) diff --git a/google/cloud/storage/internal/retry_object_read_source.cc b/google/cloud/storage/internal/retry_object_read_source.cc index 513a91c514c5b..eea8b82d31f02 100644 --- a/google/cloud/storage/internal/retry_object_read_source.cc +++ b/google/cloud/storage/internal/retry_object_read_source.cc @@ -14,7 +14,6 @@ #include "google/cloud/storage/internal/retry_object_read_source.h" #include "google/cloud/internal/make_status.h" -#include "google/cloud/log.h" #include #include #include @@ -69,7 +68,6 @@ RetryObjectReadSource::RetryObjectReadSource( StatusOr RetryObjectReadSource::Read(char* buf, std::size_t n) { - GCP_LOG(INFO) << ", offset=" << current_offset_; if (!child_) { return google::cloud::internal::FailedPreconditionError( "Stream is not open", GCP_ERROR_INFO()); @@ -90,8 +88,6 @@ StatusOr RetryObjectReadSource::Read(char* buf, auto backoff_policy = backoff_policy_prototype_->clone(); auto retry_policy = retry_policy_prototype_->clone(); int counter = 0; - GCP_LOG(INFO) << "Retry on =" << result.status() - << ", offset=" << current_offset_ << ", counter=" << counter; while (!result && retry_policy->OnFailure(result.status())) { // A Read() request failed, most likely that means the connection failed or // stalled. The current child might no longer be usable, so we will try to @@ -129,8 +125,6 @@ StatusOr RetryObjectReadSource::Read(char* buf, if (HandleResult(result)) return result; // We have exhausted the retry policy, return the error. auto status = std::move(result).status(); - GCP_LOG(INFO) << "Exhausted retry policy during Read(), status=" << status - << ", offset=" << current_offset_ << ", counter=" << counter; std::ostringstream os; if (internal::StatusTraits::IsPermanentFailure(status)) { os << "Permanent error in Read(): " << status.message(); @@ -142,7 +136,6 @@ StatusOr RetryObjectReadSource::Read(char* buf, bool RetryObjectReadSource::HandleResult(StatusOr const& r) { if (!r) return false; - GCP_LOG(INFO) << ", offset=" << current_offset_; if (r->generation) generation_ = r->generation; if (r->transformation.value_or("") == "gunzipped") is_gunzipped_ = true; // Since decompressive transcoding does not respect `ReadLast()` we need @@ -156,10 +149,8 @@ bool RetryObjectReadSource::HandleResult(StatusOr const& r) { return true; } -// NOLINTNEXTLINE(misc-no-recursion) Status RetryObjectReadSource::MakeChild(RetryPolicy& retry_policy, BackoffPolicy& backoff_policy) { - GCP_LOG(INFO) << ", offset=" << current_offset_; auto on_success = [this](std::unique_ptr child) { child_ = std::move(child); return Status{};