Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable gkeconnect in quickstart ci builds #14896

Open
scotthart opened this issue Dec 11, 2024 · 1 comment
Open

reenable gkeconnect in quickstart ci builds #14896

scotthart opened this issue Dec 11, 2024 · 1 comment
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

gkeconnect needs a release cycle to switch from using grpc connection headers to rest connection heads in the quickstart builds that rely on previous releases on google-cloud-cpp

@scotthart scotthart added the type: cleanup An internal cleanup or hygiene concern. label Dec 11, 2024
@dbolduc
Copy link
Member

dbolduc commented Dec 11, 2024

When the time comes, we should also see if we can get it to run successfully instead of expecting errors

COMMAND
cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
$<TARGET_FILE:gkeconnect_quickstart> GOOGLE_CLOUD_PROJECT
GOOGLE_CLOUD_CPP_TEST_REGION
# use GOOGLE_CLOUD_CPP_BIGTABLE_TEST_INSTANCE_ID as input
# membership-id. we don't expect it to be valid.
GOOGLE_CLOUD_CPP_BIGTABLE_TEST_INSTANCE_ID)
set_tests_properties(
gkeconnect_quickstart
PROPERTIES
LABELS "integration-test;quickstart" PASS_REGULAR_EXPRESSION
"google::cloud::Status thrown: INVALID_ARGUMENT: Permanent error")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants