Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: All toPb() methods access level changed to public #1196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TurtleBeatboxer
Copy link

@TurtleBeatboxer TurtleBeatboxer commented Sep 23, 2023

Minor change, but requested in issue #1007

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1007 ☕️

mmarzecki and others added 2 commits September 23, 2023 17:06
@google-cla
Copy link

google-cla bot commented Sep 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Sep 23, 2023
@TurtleBeatboxer TurtleBeatboxer changed the title all-toPb-made-public Fix: All toPb() methods access level changed to public Sep 23, 2023
@TurtleBeatboxer TurtleBeatboxer marked this pull request as ready for review September 23, 2023 16:29
@TurtleBeatboxer TurtleBeatboxer requested review from a team as code owners September 23, 2023 16:29
@TurtleBeatboxer
Copy link
Author

TurtleBeatboxer commented Sep 23, 2023

Why there are several non resolvable checks saying: "Expected - Waiting for the status to be reported" even though I did tests and reopened the pull request quite a few times?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make toPb methods public
1 participant