Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyroscope to homebrew-core #156

Closed
5 tasks
petethepig opened this issue Apr 15, 2021 · 0 comments
Closed
5 tasks

Add pyroscope to homebrew-core #156

petethepig opened this issue Apr 15, 2021 · 0 comments
Labels
packages Related to packaging of the software. homebrew, rpm, deb, docker, etc

Comments

@petethepig
Copy link
Member

petethepig commented Apr 15, 2021

Summary

Currently we have a separate repo and people install pyroscope via a tap:

brew install pyroscope-io/brew/pyroscope

This is great but it would be even better if they could just do:

brew install pyroscope

I think we're big enough at this point that we can be added to homebrew core. This will make the installation simpler and makes us look more legit.

TODO

  • go through the process of adding pyroscope to homebrew
  • update release scripts (talk to @petethepig about this) to trigger a github action to create a PR against the homebrew-core repo.
  • make sure both our tap and the homebrew-core versions work properly (once we have the formula in homebrew-core repo we can set up some github action to basically make our tap a mirror of that formula I think)
  • add linux support? I saw people using that recently, e.g here
  • set up a smoke test that would run brew bottle for each commit, ensuring that it's not failing (this is important because we often make changes to the build process and it's important to have tests that ensure everything is still working)
@petethepig petethepig added the packages Related to packaging of the software. homebrew, rpm, deb, docker, etc label Apr 15, 2021
@petethepig petethepig changed the title Proper brew support Add pyroscope to homebrew-core Apr 15, 2021
korniltsev pushed a commit that referenced this issue Jul 18, 2023
* Remove files with incorrect case

* Added files with proper case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Related to packaging of the software. homebrew, rpm, deb, docker, etc
Projects
None yet
Development

No branches or pull requests

2 participants