Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance with Awesome list guidelines #14

Open
tzwel opened this issue Jun 15, 2024 · 9 comments
Open

Compliance with Awesome list guidelines #14

tzwel opened this issue Jun 15, 2024 · 9 comments

Comments

@tzwel
Copy link
Collaborator

tzwel commented Jun 15, 2024

Thinking about submitting to Awesome but that would require substantial changes, such as renaming the master branch, and also a better direction for the project.

Currently the name of the list is awesome-unique-id which seems language-agnostic, however almost every submission is for JavaScript. What about renaming the list to something like awesome-unique-id-js, awesome-js-unique-id or awesome-javascript-id (my personal favorite)?

@tzwel tzwel changed the title Better direction? Better direction? (Rename repo?) Jun 15, 2024
@grantcarthew
Copy link
Owner

I made this list when I was working with JS heavily. I had it as a private file on my computer initially. Once the whole Awesome thing popped up, I created this repo, but to be an official Awesome repo there were a couple of requirements I didn't quite meet. I lost interest as I moved on to other things.

The RoboHash site is just fantastic and I love it. I use it now and again. My current work for example has a CI/CD automation user who didn't have a profile image. It's great for that sort of thing.

I planned to add more ID technologies, but life got in the way. For example, my current struggle is getting screenshots working on Wayland. It is such a dogs breakfast that I'm going to put that off until support has improved I think. I digress.

Is there an awesome id project written in Golang? What about Rust? I would say there are a heap of other tech id packages we could add.

Some of those research papers you linked to could be added also.

I don't think I want to turn this into JAJSR (just another js repo). Id technology and all that surrounds it is fascinating.

Let's keep it generic. In fact, please add research papers as a heading @tzwel.

I will rename the master branch right now.

@grantcarthew
Copy link
Owner

The master branch has been renamed to main. Please update your local clones.

@tzwel
Copy link
Collaborator Author

tzwel commented Jun 16, 2024

Got it, added in ffa9e05

I'll keep this open in case we want to turn this completely Awesome-friendly and submit in the future. Maybe then people will contribute libs for other languages

@tzwel
Copy link
Collaborator Author

tzwel commented Jun 16, 2024

So to be sure, it's fine if I make changes to comply with the Awesome list guidelines?

@grantcarthew
Copy link
Owner

Yes, make it your own. If you are keen on making it a JS only repo, let me know and I'll rename it. I'm not too invested in this. Happy to have someone else run with it and improve what they can. Thanks for you help.

@tzwel
Copy link
Collaborator Author

tzwel commented Jun 16, 2024

Let's stick with your idea and not make this js-only, it might be beneficial in the future.

Thanks for you help.

You are welcome, it's very fun!

@tzwel tzwel changed the title Better direction? (Rename repo?) Compliance with Awesome list guidelines Jun 17, 2024
@tzwel
Copy link
Collaborator Author

tzwel commented Jun 17, 2024

  README.md:1:84
  ×   1:1   License was not detected by GitHub  remark-lint:awesome-github
  ×   1:1   Forbidden license section found     remark-lint:awesome-license
  ×   1:84  #contributors                       remark-lint:double-link
  ×  13:3   #contributors                       remark-lint:double-link

Here's what we have to fix to adhere to awesome list guidelines. Relicensing mandatory, and you choose what to do with the contributors sections

@grantcarthew
Copy link
Owner

I'm not running the linter tzwel, but that should do it.

@tzwel
Copy link
Collaborator Author

tzwel commented Jun 17, 2024

All good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants